From f8d199805cf54030641f804852202eb9e6c9b7c7 Mon Sep 17 00:00:00 2001
From: Ian Moffett <ian@osmora.org>
Date: Tue, 14 Oct 2025 15:56:08 -0400
Subject: kern: proc: Check argc after checking envblk

Fixes a crash with using this syscall

Signed-off-by: Ian Moffett <ian@osmora.org>
---
 src/sys/os/os_proc.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/src/sys/os/os_proc.c b/src/sys/os/os_proc.c
index 565c663..582c077 100644
--- a/src/sys/os/os_proc.c
+++ b/src/sys/os/os_proc.c
@@ -432,13 +432,12 @@ sys_getargv(struct syscall_args *scargs)
     struct penv_blk *envblk;
     char *arg;
 
-    if (argno >= envblk->argc) {
-        return -EINVAL;
-    }
-
     if ((envblk = self->envblk) == NULL) {
         return -EIO;
     }
+    if (argno >= envblk->argc) {
+        return -EINVAL;
+    }
 
     arg = envblk->argv[argno];
     return copyoutstr(arg, u_buf, maxlen);
-- 
cgit v1.2.3