From 02ca8f9faf6b6ddd0b7a514503b223e9ecbe8fe9 Mon Sep 17 00:00:00 2001 From: Ian Moffett Date: Thu, 15 May 2025 17:41:29 -0400 Subject: kernel: proc: Do not introduce fork() Simplicity is divine, fork() may be powerful but is no longer simple. It became a thing in the late 70s during the early days of UNIX when computing was simple, when CPUs were only 16-bits, MMUs were not prevalent and RAM was only 512 KB. However it isn't 1971 anymore, process management, CPUs and memory architecture has advanced significantly since. This commit ceases work on the fork() syscall as implementing it would only introduce unnecessary complexity, security issues, hefty processing overhead and would perpetuate what should now be considered legacy. The current best alternative would be providing a form of process spawning as well as a mechanism to wait for the child process to complete. Signed-off-by: Ian Moffett --- sys/arch/amd64/amd64/proc_machdep.c | 2 +- sys/arch/amd64/isa/i8042.c | 2 +- sys/include/sys/proc.h | 3 +- sys/kern/init_main.c | 2 +- sys/kern/kern_fork.c | 87 --------------------------------- sys/kern/kern_spawn.c | 96 +++++++++++++++++++++++++++++++++++++ 6 files changed, 101 insertions(+), 91 deletions(-) delete mode 100644 sys/kern/kern_fork.c create mode 100644 sys/kern/kern_spawn.c (limited to 'sys') diff --git a/sys/arch/amd64/amd64/proc_machdep.c b/sys/arch/amd64/amd64/proc_machdep.c index 0be85fd..9579b7e 100644 --- a/sys/arch/amd64/amd64/proc_machdep.c +++ b/sys/arch/amd64/amd64/proc_machdep.c @@ -155,7 +155,7 @@ md_td_kick(struct proc *td) * @ip: Instruction pointer. */ int -md_fork(struct proc *p, struct proc *parent, uintptr_t ip) +md_spawn(struct proc *p, struct proc *parent, uintptr_t ip) { uintptr_t stack_base; struct trapframe *tfp; diff --git a/sys/arch/amd64/isa/i8042.c b/sys/arch/amd64/isa/i8042.c index 89bebc5..46a8d19 100644 --- a/sys/arch/amd64/isa/i8042.c +++ b/sys/arch/amd64/isa/i8042.c @@ -436,7 +436,7 @@ i8042_init(void) quirks |= I8042_HOSTILE; pr_trace("lenovo device, assuming hostile\n"); pr_trace("disabling irq 1, polling as fallback\n"); - fork1(&polltd, 0, i8042_sync_loop, NULL); + spawn(&polltd, 0, i8042_sync_loop, NULL); } if (!ISSET(quirks, I8042_HOSTILE)) { diff --git a/sys/include/sys/proc.h b/sys/include/sys/proc.h index c561e91..d252ab7 100644 --- a/sys/include/sys/proc.h +++ b/sys/include/sys/proc.h @@ -76,7 +76,8 @@ struct proc { #define PROC_EXEC BIT(1) /* Exec called (cleared by sched) */ struct proc *this_td(void); -int md_fork(struct proc *p, struct proc *parent, uintptr_t ip); +int md_spawn(struct proc *p, struct proc *parent, uintptr_t ip); +int spawn(struct proc *cur, int flags, void(*ip)(void), struct proc **newprocp); void md_td_stackinit(struct proc *td, void *stack_top, struct exec_prog *prog); __dead void md_td_kick(struct proc *td); diff --git a/sys/kern/init_main.c b/sys/kern/init_main.c index 667bb97..911785a 100644 --- a/sys/kern/init_main.c +++ b/sys/kern/init_main.c @@ -101,7 +101,7 @@ main(void) /* Startup pid 1 */ memset(&proc0, 0, sizeof(proc0.tf)); - fork1(&proc0, 0, start_init, NULL); + spawn(&proc0, 0, start_init, NULL); /* Load all drivers */ DRIVERS_INIT(); diff --git a/sys/kern/kern_fork.c b/sys/kern/kern_fork.c deleted file mode 100644 index abb7707..0000000 --- a/sys/kern/kern_fork.c +++ /dev/null @@ -1,87 +0,0 @@ -/* - * Copyright (c) 2023-2025 Ian Marco Moffett and the Osmora Team. - * All rights reserved. - * - * Redistribution and use in source and binary forms, with or without - * modification, are permitted provided that the following conditions are met: - * - * 1. Redistributions of source code must retain the above copyright notice, - * this list of conditions and the following disclaimer. - * 2. Redistributions in binary form must reproduce the above copyright - * notice, this list of conditions and the following disclaimer in the - * documentation and/or other materials provided with the distribution. - * 3. Neither the name of Hyra nor the names of its - * contributors may be used to endorse or promote products derived from - * this software without specific prior written permission. - * - * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" - * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE - * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE - * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR - * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF - * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS - * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN - * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) - * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE - * POSSIBILITY OF SUCH DAMAGE. - */ - -#include -#include -#include -#include -#include -#include -#include -#include -#include - -static size_t nthreads = 0; - -/* - * Fork1 - fork and direct a thread to 'ip' - * - * @cur: Current process. - * @flags: Flags to set. - * @ip: Location for new thread to start at. - * @newprocp: Will contain new thread if not NULL. - */ -int -fork1(struct proc *cur, int flags, void(*ip)(void), struct proc **newprocp) -{ - struct proc *newproc; - struct mmap_lgdr *mlgdr; - int status = 0; - - newproc = dynalloc(sizeof(*newproc)); - if (newproc == NULL) - return -ENOMEM; - - mlgdr = dynalloc(sizeof(*mlgdr)); - if (mlgdr == NULL) - return -ENOMEM; - - memset(newproc, 0, sizeof(*newproc)); - status = md_fork(newproc, cur, (uintptr_t)ip); - if (status != 0) - goto done; - - /* Set proc output if we can */ - if (newprocp != NULL) - *newprocp = newproc; - - /* Initialize the mmap ledger */ - mlgdr->nbytes = 0; - RBT_INIT(lgdr_entries, &mlgdr->hd); - newproc->mlgdr = mlgdr; - - newproc->pid = ++nthreads; - signals_init(newproc); - sched_enqueue_td(newproc); -done: - if (status != 0) - dynfree(newproc); - - return status; -} diff --git a/sys/kern/kern_spawn.c b/sys/kern/kern_spawn.c new file mode 100644 index 0000000..6adf726 --- /dev/null +++ b/sys/kern/kern_spawn.c @@ -0,0 +1,96 @@ +/* + * Copyright (c) 2023-2025 Ian Marco Moffett and the Osmora Team. + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * + * 1. Redistributions of source code must retain the above copyright notice, + * this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in the + * documentation and/or other materials provided with the distribution. + * 3. Neither the name of Hyra nor the names of its + * contributors may be used to endorse or promote products derived from + * this software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE + * ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE + * LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR + * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF + * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS + * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN + * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) + * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE + * POSSIBILITY OF SUCH DAMAGE. + */ + +#include +#include +#include +#include +#include +#include +#include +#include +#include + +#define pr_trace(fmt, ...) kprintf("spawn: " fmt, ##__VA_ARGS__) +#define pr_error(...) pr_trace(__VA_ARGS__) + +static volatile size_t nthreads = 0; + +/* + * Spawn a new process + * + * @cur: Parent (current) process. + * @flags: Spawn flags. + * @ip: Location for process to start + * @newprocp: If not NULL, will contain the new process. + */ +int +spawn(struct proc *cur, int flags, void(*ip)(void), struct proc **newprocp) +{ + struct proc *newproc; + struct mmap_lgdr *mlgdr; + int error; + + newproc = dynalloc(sizeof(*newproc)); + if (newproc == NULL) { + pr_error("could not alloc proc (-ENOMEM)\n"); + return -ENOMEM; + } + + mlgdr = dynalloc(sizeof(*mlgdr)); + if (mlgdr == NULL) { + dynfree(newproc); + pr_error("could not alloc proc mlgdr (-ENOMEM)\n"); + return -ENOMEM; + } + + memset(newproc, 0, sizeof(*newproc)); + error = md_spawn(newproc, cur, (uintptr_t)ip); + if (error < 0) { + dynfree(newproc); + dynfree(mlgdr); + pr_error("error initializing proc\n"); + return error; + } + + /* Set proc output if we can */ + if (newprocp != NULL) { + *newprocp = newproc; + } + + /* Initialize the mmap ledger */ + mlgdr->nbytes = 0; + RBT_INIT(lgdr_entries, &mlgdr->hd); + newproc->mlgdr = mlgdr; + + newproc->pid = ++nthreads; + signals_init(newproc); + sched_enqueue_td(newproc); + return 0; +} -- cgit v1.2.3