From a03ee844910a348c905de484ee0a0bac24b21a3d Mon Sep 17 00:00:00 2001
From: Ian Moffett <ian@osmora.org>
Date: Tue, 1 Jul 2025 21:18:22 -0400
Subject: kernel: ctlfs: Add ctlfs_get_ops() to fetch ctlops

This commit cleans up the read routine by creating a helper that fetches
common fields from the ctlfs entry while checking things such as its
magic number.

Signed-off-by: Ian Moffett <ian@osmora.org>
---
 sys/fs/ctlfs.c | 43 ++++++++++++++++++++++++++++++++-----------
 1 file changed, 32 insertions(+), 11 deletions(-)

(limited to 'sys/fs')

diff --git a/sys/fs/ctlfs.c b/sys/fs/ctlfs.c
index 9225114..18a0275 100644
--- a/sys/fs/ctlfs.c
+++ b/sys/fs/ctlfs.c
@@ -234,6 +234,35 @@ ctlfs_lookup(struct vop_lookup_args *args)
     return 0;
 }
 
+static int
+ctlfs_get_ops(struct vnode *vp, struct ctlfs_entry **enpres,
+    const struct ctlops **iopres)
+{
+    const struct ctlops *iop;
+    struct ctlfs_entry *enp;
+
+    if (enpres == NULL || iopres == NULL) {
+        return -EINVAL;
+    }
+
+    if ((enp = vp->data) == NULL) {
+        pr_error("no vnode data for ctlfs entry\n");
+        return -EIO;
+    }
+    if (enp->magic != CTLFS_ENTRY_MAG) {
+        pr_error("ctlfs entry has bad magic\n");
+        return -EIO;
+    }
+    if ((iop = enp->io) == NULL) {
+        pr_error("no i/o ops for ctlfs entry\n");
+        return -EIO;
+    }
+
+    *enpres = enp;
+    *iopres = iop;
+    return 0;
+}
+
 /*
  * Create a ctlfs node (directory) within the
  * root fs.
@@ -344,18 +373,10 @@ ctlfs_read(struct vnode *vp, struct sio_txn *sio)
     const struct ctlops *iop;
     struct ctlfs_entry *enp;
     struct ctlfs_dev dev;
+    int error;
 
-    if ((enp = vp->data) == NULL) {
-        pr_error("no vnode data for ctlfs entry\n");
-        return -EIO;
-    }
-    if (enp->magic != CTLFS_ENTRY_MAG) {
-        pr_error("ctlfs entry has bad magic\n");
-        return -EIO;
-    }
-    if ((iop = enp->io) == NULL) {
-        pr_error("no i/o ops for ctlfs entry\n");
-        return -EIO;
+    if ((error = ctlfs_get_ops(vp, &enp, &iop)) < 0) {
+        return error;
     }
     if (iop->read == NULL) {
         pr_trace("no read op for ctlfs entry\n");
-- 
cgit v1.2.3