summaryrefslogtreecommitdiff
path: root/sys/dev/pci
diff options
context:
space:
mode:
authorIan Moffett <ian@osmora.org>2024-06-03 20:36:18 -0400
committerIan Moffett <ian@osmora.org>2024-06-03 20:36:18 -0400
commit214eadc62b5578f76c98a38a28f8b3d80ac4d6ad (patch)
tree9e104caa48a12511d11a0833afb8005f1fb65e0d /sys/dev/pci
parent46b556a8c7fdbfaa9a11306dea197b2d7363e97c (diff)
kernel: pci: Require mapping BAR using bus_map()
This commit gets rid of pci_map_bar() as some devices have their base address spanning mulitple BARs. This change also exposes PCI bar size logic through pci_bar_size() Signed-off-by: Ian Moffett <ian@osmora.org>
Diffstat (limited to 'sys/dev/pci')
-rw-r--r--sys/dev/pci/pci.c22
1 files changed, 10 insertions, 12 deletions
diff --git a/sys/dev/pci/pci.c b/sys/dev/pci/pci.c
index 3be61d9..9a8eae4 100644
--- a/sys/dev/pci/pci.c
+++ b/sys/dev/pci/pci.c
@@ -205,21 +205,21 @@ pci_get_barreg(struct pci_device *dev, uint8_t bar)
}
/*
- * Map a PCI(e) BAR into kernel memory.
+ * Get size length of memory region that a PCI(e) BAR
+ * covers. A returned value of zero is invalid and indicates
+ * an error.
*
- * @dev: Device of BAR to map.
- * @bar: BAR number to map.
- * @vap: Resulting virtual address.
+ * @dev: Device of BAR to get.
+ * @bar: BAR number.
*/
-int
-pci_map_bar(struct pci_device *dev, uint8_t bar, void **vap)
+uint32_t
+pci_bar_size(struct pci_device *dev, uint8_t bar)
{
uint8_t bar_reg = pci_get_barreg(dev, bar);
- uintptr_t tmp;
- uint32_t size;
+ uint32_t tmp, size;
if (bar_reg == 0) {
- return -EINVAL;
+ return 0;
}
/*
@@ -235,9 +235,7 @@ pci_map_bar(struct pci_device *dev, uint8_t bar, void **vap)
/* Now we need to restore the previous value */
pci_writel(dev, bar_reg, tmp);
-
- /* Now do the actual mapping work */
- return bus_map(dev->bar[bar], size, 0, vap);
+ return size;
}
/*